11 Dec
2020
11 Dec
'20
9:55 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48434 )
Change subject: soc/amd/common/block/smbus: refactor fch_smbus_init ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48434/2/src/soc/amd/common/block/sm... File src/soc/amd/common/block/smbus/smbus_early_fch.c:
https://review.coreboot.org/c/coreboot/+/48434/2/src/soc/amd/common/block/sm... PS2, Line 23: fch_smbus_enable_decode(SMB_BASE_ADDR); Since CB:29258 smbus_writeX() below is MMIO, while function above is for IO decode.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8072ab78985021d19b6528100c674ecdd777e62e
Gerrit-Change-Number: 48434
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 11 Dec 2020 20:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment