Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: Picasso: Load x86 microcode from CBFS modules
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41719/1/src/soc/amd/picasso/cpu.c
File src/soc/amd/picasso/cpu.c:
https://review.coreboot.org/c/coreboot/+/41719/1/src/soc/amd/picasso/cpu.c@1...
PS1, Line 123: { X86_VENDOR_AMD, 0x810f81 },
duplicate of PICASSO_CPUID
also I've added more CPUIDs in this still unmerged patch https://review.coreboot.org/c/coreboot/+/41641/6/src/soc/amd/picasso/include...
Beware though that the current Mandolin code doesn't apply or work with current master. The plan is to land Google/zork in upstream and then getting Mandolin to work again on upstream; there were some breaking changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib08a65b93c045afc97952a809670c85831c0faf7
Gerrit-Change-Number: 41719
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 16:32:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment