Attention is currently required from: Ravi kumar, Paul Menzel, Ravi Kumar Bokka, Julius Werner, mturney mturney.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support
......................................................................
Patch Set 26:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45206/comment/1793f4e2_6dff37b1
PS15, Line 8:
- Is this code copied? […]
In addition to the description Paul is asking for can you please add:
BUG=b:182963902
TEST= (how you tested that this code was correct)
Patchset:
PS26:
Also, it seems you need to get rid of the whitespace in order to get build bot to stop complaining:
File src/mainboard/google/herobrine/boardid.c:9: has lines ending with whitespace.
File src/mainboard/google/herobrine/boardid.c:16: has lines ending with whitespace.
File src/mainboard/google/herobrine/boardid.c:23: has lines ending with whitespace.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I428cf1a461ee63215f5683abbfed90202d1b2a88
Gerrit-Change-Number: 45206
Gerrit-PatchSet: 26
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 17 Mar 2021 06:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment