Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )
Change subject: soc/mediatek/mt8192: devapc: add basic devapc drivers ......................................................................
Patch Set 51:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46402/25//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46402/25//COMMIT_MSG@8 PS25, Line 8:
please add some short description for what is a devapc, and why you have to init infra/peri (e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 6: unsigned long
uintptr_t
Done
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 6: unsigned long
uintptr_t
Done
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 12: &val
you're setting at address zero? […]
Done
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 14: void*)MAS_SEC
maybe put this as variable […]
Done
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 28: master_sec_init
what about rename this to your comment - init_master_sideband() ?
Done