Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39850 )
Change subject: mb/google/hatch/vr/puff: Add psys_pmax calculation
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/...
PS4, Line 90: 15k
k is kilo, 1000. The unit here is ohms.
Could you add the unit despite it cancelling each other out?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ea01f856411e05a533489280fc2b4a46a1440c5
Gerrit-Change-Number: 39850
Gerrit-PatchSet: 6
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Harry Pan
harry.pan@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Apr 2020 15:25:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gaggery Tsai
gaggery.tsai@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment