Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38121 )
Change subject: lib/spd_bin,soc/intel/common: Move get_spd_smbus()
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38121/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/38121/3/src/soc/intel/common/block/...
PS3, Line 220: ((u16*)spd)[i / sizeof(uint16_t)] =
"(foo*)" should be "(foo *)"
Meh, the code should be reflowed as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2d9d83ede6388a01d40c6e4768f6bb6bf899c00
Gerrit-Change-Number: 38121
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jan 2020 15:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment