Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46419 )
Change subject: mb/intel/adlrvp: Enable PCIE RP11 for optane
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46419/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46419/1//COMMIT_MSG@8
PS1, Line 8:
So, if I understand correctly: […]
Ack
https://review.coreboot.org/c/coreboot/+/46419/1//COMMIT_MSG@9
PS1, Line 9: config
nit: add `:` at the end
Ack
https://review.coreboot.org/c/coreboot/+/46419/1//COMMIT_MSG@13
PS1, Line 13: Note: These two devices are sharing CLK PINs.
This is because they use the same M. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46419
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia21d7d2fd07c4fb32291af7bb5a2e41e40316278
Gerrit-Change-Number: 46419
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Oct 2020 04:12:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment