Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel/Kconfig: Introduce and use FIXED BARs_ADDRESS symbols ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45610/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45610/16//COMMIT_MSG@7 PS16, Line 7: northbridge/intel/Kconfig: Introduce and use FIXED BARs_ADDRESS symbols : : FIXED_MCHBAR_ADDRESS value will be used to define DEFAULT_MCHBAR, : FIXED_DMIBAR_ADDRESS for DEFAULT_DMIBAR and FIXED_EPBAR_ADDRESS for : DEFAULT_EPBAR There's no need to write so much stuff in uppercase, and giving a reason would be nice as well:
northbridge/intel: Move base addresses to Kconfig
Define the fixed base addresses for MCHBAR, DMIBAR and EPBAR in Kconfig. This allows having common accessor functions for these MMIO ranges while still allowing each northbridge to specify the values for the base addresses.
Keep the DEFAULT_{MCH,DMI,EP}BAR macros for now. Removing them in this change would unnecessarily create too much noise.