[coreboot-gerrit] Change in coreboot[master]: arch/x86: Implement RESET_VECTOR_IN_RAM

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )

Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM
......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/memlayout.ld 
File src/arch/x86/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/memlayout.ld@... 
PS15, Line 66: #if !CONFIG(RESET_VECTOR_IN_RAM)
> nit: I would prefer guards, if necessary, inside id.ld with some commentary. […]

I think I like the guards a little bit better here, but it's not a strong preference at all.  I could go with either way.

On the value of including the ID into a picasso image, I struggled to find any.  It won't be discoverable in the ROM image because it's inside of a compressed image.  And if it's assumed to be in place runtime just below 4GB, a better solution might be a small non-bootblock piece of data we can place at the top of flash.