Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41910 )
Change subject: arch/x86: Declare permanent_smi_handler() ......................................................................
Patch Set 3:
(1 comment)
Some hunks are not about the FADT advertisement. Which makes it hard to assess which cases of `if(CONFIG(HAVE_SMI_HANDLER))` should be updated with this patch and which shouldn't. For instance, there are several instances that were not updated in amd chipset code that configure the APM_CNT port. Will they be updated later? Do they need an update at all?
https://review.coreboot.org/c/coreboot/+/41910/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/41910/3/src/include/acpi/acpi.h@101... PS3, Line 1014: static inline int permanent_smi_handler(void) A comment would be nice, what defines a "permanent" handler.