[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 )

Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID
......................................................................

Patch Set 5:
> > Is this just setting subsystem ids of a PCI device? These should
>
> be
> > set in the devicetree and no blob needed.
> >
> > If yes, this seems backwards. Shouldn't we set the id of the PCI
> > device first and when configuring the codec take the id of the
>
> PCI
> > device?
>
> From https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/soun...,
> line 651, we can see kernel driver is comparing the ssid with pci
> and verb.
>
> ass = codec->core.subsystem_id & 0xffff;
> if (codec->bus->pci &&
> ass != codec->bus->pci->subsystem_device && (ass & 1))
> goto do_sku;
>
> I believe the ssid of detail codec is fixed, then we have to modify
> BUS ssid to match with it. I have similar concern earlier in 29490.

Sorry I have make same comment more than once, seems something wrong with my browser.