Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43612 )
Change subject: ec/system76_ec: add support for System76 EC ......................................................................
Patch Set 14: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/43612/8/src/ec/system76/ec/Kconfig File src/ec/system76/ec/Kconfig:
https://review.coreboot.org/c/coreboot/+/43612/8/src/ec/system76/ec/Kconfig@... PS8, Line 7: bool
This would need to "depends on EC_SYSTEM76_EC"
Done
https://review.coreboot.org/c/coreboot/+/43612/8/src/ec/system76/ec/Kconfig@... PS8, Line 8: default n
indent should use tabs
Done
https://review.coreboot.org/c/coreboot/+/43612/8/src/ec/system76/ec/system76... File src/ec/system76/ec/system76_ec.c:
https://review.coreboot.org/c/coreboot/+/43612/8/src/ec/system76/ec/system76... PS8, Line 32: wait_us(10000, system76_ec_read(0) == 0);
Tabs, tabs, tabs 😋
Done