Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37767 )
Change subject: util/inteltool: drop OS-specific rdmsr functions
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/Makefile
File util/inteltool/Makefile:
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/Makefile@26
PS1, Line 26: CFLAGS += -Wno-unused-function
I'm a little puzzled by why this is happening. […]
Done
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/inteltool.h@...
PS1, Line 374: int freebsd_wrmsr(int addr, msr_t msr);
I think these two prototypes can just be removed instead, since they aren't used outside of cpu. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aba72f39b528fd70451a4656fd6c835ff766e49
Gerrit-Change-Number: 37767
Gerrit-PatchSet: 3
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 21 Dec 2019 15:42:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Comment-In-Reply-To: Idwer Vollering
vidwer@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment