Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37401 )
Change subject: mb/*/*: use ACPIMMIO common block wherever possible ......................................................................
Patch Set 6:
(4 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/37401/6/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/gpio_ftns.c:
https://review.coreboot.org/c/coreboot/+/37401/6/src/mainboard/pcengines/apu... PS6, Line 22: static u8 gpio_read_wrapper(u32 gpio) u32 ?
https://review.coreboot.org/c/coreboot/+/37401/6/src/mainboard/pcengines/apu... PS6, Line 31: return 0xff; die() ?
https://review.coreboot.org/c/coreboot/+/37401/6/src/mainboard/pcengines/apu... PS6, Line 80: if (gpio1_read8(0x02) & BIT0) index |= BIT0;
trailing statements should be on next line
split line please
https://review.coreboot.org/c/coreboot/+/37401/6/src/mainboard/pcengines/apu... PS6, Line 81: if (gpio1_read8(0x06) & BIT0) index |= BIT1;
trailing statements should be on next line
split line please