This change is ready for review.
4 comments:
File src/mainboard/pcengines/apu2/gpio_ftns.c:
Patch Set #6, Line 22: static u8 gpio_read_wrapper(u32 gpio)
u32 ?
Patch Set #6, Line 31: return 0xff;
die() ?
Patch Set #6, Line 80: if (gpio1_read8(0x02) & BIT0) index |= BIT0;
trailing statements should be on next line
split line please
Patch Set #6, Line 81: if (gpio1_read8(0x06) & BIT0) index |= BIT1;
trailing statements should be on next line
split line please
To view, visit change 37401. To unsubscribe, or for help writing mail filters, visit settings.