Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mainboard/google/hatch: create akemi variant. ......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33824/22/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/33824/22/src/mainboard/google/hatch... PS22, Line 125: /* F3 : MEM_STRAP_3 */ : PAD_CFG_GPI(GPP_F3, NONE, PLTRST), : /* F10 : MEM_STRAP_2 */ : PAD_CFG_GPI(GPP_F10, NONE, PLTRST), The MEM_STRAP_* pins are not required to be in the early_gpio_table. Can you remove all 4 and then add this comment above the declaration?
/* * GPIOs configured before ramstage * Note: the Hatch platform's romstage will configure * the MEM_STRAP_* (a.k.a GPIO_MEM_CONFIG_*) pins * as inputs before it reads them, so they are not * needed in this table. */
https://review.coreboot.org/c/coreboot/+/33824/22/src/mainboard/google/hatch... PS22, Line 153: /* H19 : MEM_STRAP_0 */ : PAD_CFG_GPI(GPP_H19, NONE, PLTRST), : /* H22 : MEM_STRAP_1 */ : PAD_CFG_GPI(GPP_H22, NONE, PLTRST), See above, these are not required