31 Oct
2020
31 Oct
'20
7:07 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47050 )
Change subject: mb/purism/librem_whl: rename to librem_cnl ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Patch Set 1: Code-Review+1
Just wanted to mention that what holds soc/intel/cannonlake/ together is actually the PCH cannonpoint/cnp.
Hrm, good point. I feel we might as well name this `librem_cfl` since CNL isn't really a thing
why would I rename to Coffeelake when none of the boards select that SoC? _cnp would be the most logical suffix given the common PCH, but I can't see _cnl vs _cnp being meaningful in any way
--
To view, visit https://review.coreboot.org/c/coreboot/+/47050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2af7977f1622070eb8bf8449bc8306f9d75b9851
Gerrit-Change-Number: 47050
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 31 Oct 2020 19:07:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment