[coreboot-gerrit] Change in coreboot[master]: Revert "drivers/intel/fsp2_0: use FSP to allocate APEI BERT memory re...

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Rocky Phagura, Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56163 )

Change subject: Revert "drivers/intel/fsp2_0: use FSP to allocate APEI BERT memory region"
......................................................................

Patch Set 1:

(1 comment)

File src/drivers/intel/fsp2_0/hob_verify.c:

https://review.coreboot.org/c/coreboot/+/56163/comment/438d24de_9bb709ac 
PS1, Line 52:
> Will this condition ever occur? Should it be caught elsewhere?

this doesn't need to be checked any more and i'm not even 100% certain if the second part of the condition in line 53 ever evaluated to true.
before we could just put the BERT region into CBMEM due to the unexpected memory type 16 of CBMEM which the Linux kernel didn't know/like, the BERT region was put above CBMEM; see the diagram in https://review.coreboot.org/c/coreboot/+/56163/1/src/drivers/intel/fsp2_0/me...
this check checked that the BERT region on top of CBMEM ends at TOLUM. When putting the BERT region into CBMEM and not reserving a section above CBMEM, CBMEM will end at TOLUM.
Or did you mean ACPI_BERT being selected? only 2 of the recent Intel laptop SoCs and the AMD laptop SoCs select this option