Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48872 )
Change subject: soc/intel/common: move "pmc_gpe_init" to the beginning of "verstage"
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48872/3/src/device/Makefile.inc
File src/device/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48872/3/src/device/Makefile.inc@a14
PS3, Line 14: bootblock-y += device_const.c
Should we remove this line for GLK only but not for all platforms? And the Jenkins did show that other platforms will get failed to build.
i386-elf-ld.bfd: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_BOBBA/bootblock/soc/intel/apollolake/uart.o: in function `soc_uart_console_to_device':
/home/coreboot/node-root/workspace/coreboot-gerrit/src/soc/intel/apollolake/uart.c:77: undefined reference to `pcidev_path_on_root'
For Octopus, looks like pcidev_path_on_root in device_const.c is still used by uart.c above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc98025b9a351078ce05a583ddafcdafaad83fd2
Gerrit-Change-Number: 48872
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Jan 2021 10:22:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment