Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: soc/intel: Add Intel Xeon Scalable Processor support ......................................................................
Patch Set 41:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/Kcon... File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/Kcon... PS40, Line 30: select ARCH_VERSTAGE_X86_32
ah I see. But we still do not need to compile anything, see my next comment for makefile. […]
Done
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/Kcon... PS40, Line 139: config CPU_BCLK_MHZ : int : default 100
I am not sure this is accurate or applies. […]
Done
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/Make... File src/soc/intel/xeon_sp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/Make... PS40, Line 59: verstage-y += soc_util.c : verstage-y += reset.c : verstage-y += spi.c
this is probably redudant
Done
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/chip... File src/soc/intel/xeon_sp/chip.c:
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/chip... PS40, Line 548: { : struct bus *nlink = dev->link_list; : while (nlink != NULL) : nlink = nlink->next; : } :
why is this block needed?
Done