William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39857 )
Change subject: mb/google/volteer: Create Malefor variant ......................................................................
Patch Set 7: Code-Review+1
(12 comments)
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 83: DN_20K
I don't think we should have those PD even in ripto.
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 91: DN_20K
Same reason.
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 101: DN_20K
Same reason.
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 108: DN_20K
Same reason.
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 173: DN_20K
GPP_D10 has a similar function with GPP_D12, and we see the GPP_D12 also use a DN_20K, so we add it […]
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 177: DN_20K
Baseboard also has a DN_20K with NF7, we follow the settings here. […]
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 232: DN_20K
The full table copy from Ripto, and Ripto used DN_20K. […]
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 257: DN_20K
Same reason.
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 291: DN_20K
Same reason.
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 293: DN_20K
Same reason.
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 295: DN_20K
Same reason.
Done
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 348: DN_20K
Same reason.
Done