Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43398 )
Change subject: drivers/intel/fsp2_0: Allow including FSPT at specified offset ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43398/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43398/1//COMMIT_MSG@11 PS1, Line 11: specify FSPT location in CBFS and user option to include FSPT.
Is is written in integration guide that the binary must be placed at the address specified in FSP bi […]
To avoid misunderstandings: When I said "relocate" I meant the rebase process as described in the FSP spec.
`cbfstool` does this rebasing. And should do so if `xip` is specified or an address is given (cf. cbfstool_convert_fsp(), in `cbfstool.c`). If that doesn't work, I think there is a bug to fix. Or maybe we talk about the non-XIP case, then my reasoning is meaningless.
So, as we are reviewing backwards here (my question on CB:43396 is unanswered), which path in the Makefile are we talking about? XIP or non-XIP case? Were both paths tested?