Hello Felix Singer, Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48400
to review the following change.
Change subject: nb/intel/sandybridge: Print delays in decimal ......................................................................
nb/intel/sandybridge: Print delays in decimal
Print delay values in a suitable format for human consumption.
Change-Id: I0d86187d3e458ee2cb3fd11ec896ac363b8d3249 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/48400/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 180d485..612d25c 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1144,7 +1144,7 @@ if (upperA[lane] < rn.middle) upperA[lane] += 128;
- printram("rcven: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n", + printram("rcven: %d, %d, %d: % 4d-% 4d-% 4d\n", channel, slotrank, lane, rn.start, rn.middle, rn.end); } } @@ -1190,7 +1190,7 @@ ctrl->timings[channel][slotrank].lanes[lane].rcven = (last_zero + first_all) / 2 + upperA[lane];
- printram("Aval: %d, %d, %d: %x\n", channel, slotrank, + printram("Aval: %d, %d, %d: % 4d\n", channel, slotrank, lane, ctrl->timings[channel][slotrank].lanes[lane].rcven); } } @@ -1406,13 +1406,13 @@
align_rt_io_latency(ctrl, channel, slotrank, prev);
- printram("4/8: %d, %d, %x, %x\n", channel, slotrank, + printram("4/8: %d, %d, % 4d, % 4d\n", channel, slotrank, ctrl->timings[channel][slotrank].roundtrip_latency, ctrl->timings[channel][slotrank].io_latency);
printram("final results:\n"); FOR_ALL_LANES - printram("Aval: %d, %d, %d: %x\n", channel, slotrank, lane, + printram("Aval: %d, %d, %d: % 4d\n", channel, slotrank, lane, ctrl->timings[channel][slotrank].lanes[lane].rcven);
MCHBAR32(GDCRTRAININGMOD) = 0; @@ -1515,7 +1515,7 @@ } } ctrl->timings[channel][slotrank].lanes[lane].tx_dq = rn.middle; - printram("tx_dq: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n", + printram("tx_dq: %d, %d, %d: % 4d-% 4d-% 4d\n", channel, slotrank, lane, rn.start, rn.middle, rn.end); } return 0; @@ -1640,7 +1640,7 @@
return MAKE_ERR; } - printram("tx_dqs: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n", + printram("tx_dqs: %d, %d, %d: % 4d-% 4d-% 4d\n", channel, slotrank, lane, rn.start, rn.middle, rn.end); } return 0; @@ -1772,7 +1772,7 @@ get_dqs_flyby_adjust(res) * 64;
printram("High adjust %d:%016llx\n", lane, res); - printram("Bval+: %d, %d, %d, %x -> %x\n", channel, slotrank, lane, + printram("Bval+: %d, %d, %d, % 4d -> % 4d\n", channel, slotrank, lane, old, ctrl->timings[channel][slotrank].lanes[lane].tx_dqs); } } @@ -2070,7 +2070,7 @@ struct run rn = get_longest_zero_run(stat[slotrank], CT_PI_LENGTH - 1);
ctrl->timings[channel][slotrank].pi_coding = rn.middle + CT_MIN_PI; - printram("cmd_stretch: %d, %d: 0x%02x-0x%02x-0x%02x\n", + printram("cmd_stretch: %d, %d: % 4d-% 4d-% 4d\n", channel, slotrank, rn.start, rn.middle, rn.end);
if (rn.all || rn.length < MIN_C320C_LEN) { @@ -2181,7 +2181,7 @@ slotrank, lane); return MAKE_ERR; } - printram("eval %d, %d, %d: %02x\n", channel, slotrank, lane, edges[lane]); + printram("eval %d, %d, %d: % 4d\n", channel, slotrank, lane, edges[lane]); } return 0; } @@ -2367,8 +2367,8 @@
rn = get_longest_zero_run(stats, MAX_EDGE_TIMING + 1);
- printram("edges: %d, %d, %d: 0x%02x-0x%02x-0x%02x, " - "0x%02x-0x%02x\n", channel, slotrank, i, rn.start, + printram("edges: %d, %d, %d: % 4d-% 4d-% 4d, " + "% 4d-% 4d\n", channel, slotrank, i, rn.start, rn.middle, rn.end, rn.start + ctrl->edge_offset[i], rn.end - ctrl->edge_offset[i]);
@@ -2529,8 +2529,8 @@ return MAKE_ERR; } printram("tx_dq: %d, %d, %d: " - "0x%02x-0x%02x-0x%02x, " - "0x%02x-0x%02x\n", channel, slotrank, + "% 4d-% 4d-% 4d, " + "% 4d-% 4d\n", channel, slotrank, i, rn.start, rn.middle, rn.end, rn.start + ctrl->tx_dq_offset[i], rn.end - ctrl->tx_dq_offset[i]); @@ -2561,7 +2561,7 @@ printram("CPB\n");
FOR_ALL_CHANNELS FOR_ALL_POPULATED_RANKS FOR_ALL_LANES { - printram("tx_dq %d, %d, %d: %x\n", channel, slotrank, lane, + printram("tx_dq %d, %d, %d: % 4d\n", channel, slotrank, lane, (lower[channel][slotrank][lane] + upper[channel][slotrank][lane]) / 2);