16 Dec
2019
16 Dec
'19
3:50 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37667 )
Change subject: libpayload: Implement reading from CBMEM console ......................................................................
Patch Set 4:
ok, the implementation itself is good enough, but I think we need some document in comment describing how to use this function. Can you add that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie324055f5fd8276f1d833fc9d04f60a792dbb9f6
Gerrit-Change-Number: 37667
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-CC: Ting Shen phoenixshen@chromium.org
Gerrit-Comment-Date: Mon, 16 Dec 2019 03:50:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment