John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31170 )
Change subject: mb/google/sarien/variants/sarien: Update thermal configuration for DPTF
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31170/5/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/include/variant/acpi/dptf.asl:
https://review.coreboot.org/#/c/31170/5/src/mainboard/google/sarien/variants...
PS5, Line 42: 5000
I am not clear on this. Please, explain why this is such a high number.
Setting 5000 for CPU Influence(mw), because this is our test result, due to CPU at performance behavior will arise to 51W, and it will meet to Tcc offset 5 & PSV95, so we need set CPU 5000 Influence(mw) to quickly pull down power, thanks.
https://review.coreboot.org/#/c/31170/5/src/mainboard/google/sarien/variants...
PS5, Line 67: 3000
How did you arrive to this number ? I would suggest to keep this at least same as PL1 minimum i.e. […]
Set PL1 MIN 3000 is for skin test, when we test high temperature ambient, we want CPU power get lower to avoid system skin test fail, and 3000 is the best that our result, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22908e4bf39aedb8cf31a9060084f6f36bff56ca
Gerrit-Change-Number: 31170
Gerrit-PatchSet: 5
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 Feb 2019 05:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment