Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45229 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssh-f board as a variant ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/45229/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45229/3//COMMIT_MSG@11 PS3, Line 11: (though no output for it)
If the integrated graphics device is unusable, I'd disable it. […]
It is said to be able to be used for compute tasks, so I will mention that.
https://review.coreboot.org/c/coreboot/+/45229/3/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md:
https://review.coreboot.org/c/coreboot/+/45229/3/Documentation/mainboard/sup... PS3, Line 37: - S3 resume not working
I had never tested S3 with vendor firmware (or maybe I just don't remember anymore). […]
Done
https://review.coreboot.org/c/coreboot/+/45229/3/Documentation/mainboard/sup... PS3, Line 39: - The IGD has an invalid state on coreboot and failed to be initialize by Linux kernel
I'd disable it then.
It is said to be able to be used for compute tasks, should I disable it currently?
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 8:
didn't check this, yet. […]
COnfirmed with inteltool/intelp2m, but with a lot of _PAD_CFG_STRUCT() unknown how to simplify.
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 229: /*** XXX TODO XXX */
that can be dropped
Done
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 32: # FIXME: find out why FSP crashes without this
does that still apply?
These can be removed.
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 73: smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthShort" "CPU SLOT6 PCI-E 3.0 X8(IN X16)" "SlotDataBusWidth8X"
I'd break these SMBIOS lines in two
Done
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 78: on
disable it since there is no output
It is said to be able to be used for compute tasks, should I disable it currently?