Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38141 )
Change subject: sb/intel/common: Add smbus_{read/write}_word() variants
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38141/3/src/southbridge/intel/commo...
File src/southbridge/intel/common/smbus.h:
https://review.coreboot.org/c/coreboot/+/38141/3/src/southbridge/intel/commo...
PS3, Line 40: unsigned int address);
Nit: this might fit on the previous line, but I guess the whole block should be reformatted anyway
We'll reformat these once they are moved.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a9432c901e7baa545d34c1d0f82212bf59f8e23
Gerrit-Change-Number: 38141
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Jan 2020 18:14:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment