Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34972 )
Change subject: lib/bootblock: Add simplified entry with basetime ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34972/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34972/3//COMMIT_MSG@11 PS3, Line 11: with calls to timestamp_add() gets removed from bootblock.
Ohh... interesting. […]
Done
https://review.coreboot.org/c/coreboot/+/34972/3/src/include/bootblock_commo... File src/include/bootblock_common.h:
https://review.coreboot.org/c/coreboot/+/34972/3/src/include/bootblock_commo... PS3, Line 49: #if 0
Remove rather than #if 0?
Done
https://review.coreboot.org/c/coreboot/+/34972/3/src/lib/bootblock.c File src/lib/bootblock.c:
https://review.coreboot.org/c/coreboot/+/34972/3/src/lib/bootblock.c@68 PS3, Line 68: void main(void)
This is for normal (non-decompressor) non-x86 builds. For example src/arch/arm64/armv8/bootblock. […]
Ack