Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36007 )
Change subject: soc/intel/braswell: Use common sb code for SPI lockdown configuration
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
Reviewed and tested on facebook fbg1701
https://review.coreboot.org/c/coreboot/+/36007/3/src/mainboard/facebook/fbg1...
File src/mainboard/facebook/fbg1701/w25q64.c:
https://review.coreboot.org/c/coreboot/+/36007/3/src/mainboard/facebook/fbg1...
PS3, Line 66: .preop = CMD_W25_WREN,
The pre-op for this platform is WREN only! […]
I checked the patch on facebook FBG1701. It's working fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e7be41a9470b37ad954d3120a67fc4d93633113
Gerrit-Change-Number: 36007
Gerrit-PatchSet: 14
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Thu, 05 Dec 2019 14:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment