Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45343 )
Change subject: device/dram: Add method for converting MHz to MT/s ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45343/2/src/device/dram/ddr4.c File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/45343/2/src/device/dram/ddr4.c@125 PS2, Line 125: >
I think Aaron's question was to understand if there is a reason why we cannot keep both min and max […]
Making the min inclusive will work fine in the current context. It does lose some precision that could matter if these values are used in another context.
https://review.coreboot.org/c/coreboot/+/45343/3/src/device/dram/ddr4.c File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/45343/3/src/device/dram/ddr4.c@141 PS3, Line 141: ddr4_speed_attributes
Why is this function required? It is doing two things: […]
Right, this function is not required. It's a just a safe wrapper for accessing the ddr4_speeds array. I was attempting to generalize a bit since this is being added to the common ddr4 library. I'll simplify for this CL.