[coreboot-gerrit] Change in coreboot[master]: cpu/intel/common: Add CAR debug Kconfig CPU_CAR_DEBUG

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Arthur Heymans, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55653 )

Change subject: cpu/intel/common: Add CAR debug Kconfig CPU_CAR_DEBUG
......................................................................

Patch Set 2:

(1 comment)

File src/cpu/intel/common/common_init.c:

https://review.coreboot.org/c/coreboot/+/55653/comment/badfd6fa_6889693d 
PS2, Line 369: 4ULL * GiB - 64 * KiB
> I guess you are trying to avoid the bootblock here, while you're calling this inside the bootblock?
> Make this explicit?
> Don't run this !ENV_BOOTBLOCK

won't earlier comment will take care of this as well?

Arthur Heymans
Jun 29
Return if not ENV_CACHE_AS_RAM?
> explicitly avoid addresses inside _bootblock/_ebootblock instead of making the hardcoded assumption on a 64K bootblock, which btw is simply not the case anymore in coreboot.