Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39226 )
Change subject: mb/google/hatch: Enable CSE Firmware Custom SKU for hatch ......................................................................
Patch Set 8:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39226/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39226/4//COMMIT_MSG@9 PS4, Line 9: It enable CSE Firmware SKU Custom for hatch board.
How about something like this: […]
Done
https://review.coreboot.org/c/coreboot/+/39226/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
PS4:
Mainboard changes should be separated from SoC changes. […]
Agreed.As of now, I am not enabling the CSE FW SKU CUSTOM for any board.
https://review.coreboot.org/c/coreboot/+/39226/4/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/39226/4/src/soc/intel/cannonlake/Kc... PS4, Line 87: SOC_INTEL_COMMON_BASECODE
I don't think we should be adding cse related code to basecode. […]
Implemented.
https://review.coreboot.org/c/coreboot/+/39226/4/src/soc/intel/cannonlake/Kc... PS4, Line 144: : config INTEL_CSE_FW_SKU_CUSTOM : bool : default n : help : Enables CSE Firmware SKU Custom.
I don't think this should be added to every Intel SoC. […]
Ack
https://review.coreboot.org/c/coreboot/+/39226/4/src/soc/intel/cannonlake/me... File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/c/coreboot/+/39226/4/src/soc/intel/cannonlake/me... PS4, Line 178: enable_cse_fw_sku_custom
I don't think we need to add this to specific SoC. […]
Done
https://review.coreboot.org/c/coreboot/+/39226/4/src/soc/intel/cannonlake/me... PS4, Line 183: BS_DEV_ENABLE
What is the reason behind making this call during this specific boot state?
Inline with other CSE operations, it's called here. But, this can be called during late ROM STAGE (after memmory initialization).