Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, SH Kim, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82100?usp=email )
Change subject: mb/google/brya/var/xol: Update I2C5 timing parameter
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82100/comment/ff161505_a44ce64e :
PS1, Line 7: Update I2C5 timing parameter
Maybe more specific: Tune I2C5 timings for touchpad spec
https://review.coreboot.org/c/coreboot/+/82100/comment/6eaba92e_c8eeab06 :
PS1, Line 9: touchpad spec
Please add the name and revision.
https://review.coreboot.org/c/coreboot/+/82100/comment/f7885cc9_a3766b52 :
PS1, Line 10:
What were the values before, and what does the spec require?
File src/mainboard/google/brya/variants/xol/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82100/comment/14ab5e64_3e5bf875 :
PS1, Line 136: .data_hold_time_ns = 50,
What is the default?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82100?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I386b2765410fd10b8cd711f54478fb52428de5a3
Gerrit-Change-Number: 82100
Gerrit-PatchSet: 1
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 29 Apr 2024 07:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment