Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42899 )
Change subject: Sc7180: Add support for sn65dsi86 bridge
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42899/7/src/drivers/ti/sn65dsi86bri...
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/42899/7/src/drivers/ti/sn65dsi86bri...
PS7, Line 470: data
As discussed over email, this needs to be masked with a DP_LANE_COUNT_MASK (0xf).
Done
https://review.coreboot.org/c/coreboot/+/42899/7/src/drivers/ti/sn65dsi86bri...
PS7, Line 484: i2c_write_field(bus, chip, SN_DPPLL_SRC_REG, ref_clk, 7, 1);
As discussed over email, this (and probably HPD) should be factored out into a separate function tha […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36a68f3241f0ba316c261a73c2f6d30fe6c3ccdc
Gerrit-Change-Number: 42899
Gerrit-PatchSet: 10
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 06 Aug 2020 12:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment