[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd: Refactor DPTC Tablet Mode

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Marshall Dawson, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66994 )

Change subject: soc/amd: Refactor DPTC Tablet Mode
......................................................................

Patch Set 9:

(3 comments)

File src/soc/amd/common/acpi/dptc.asl:

https://review.coreboot.org/c/coreboot/+/66994/comment/b26bd5ac_692ec5fb 
PS9, Line 15: 
I understand this as DPTC tablet mode. Otherwise DPTC Default. Is that correct?

File src/soc/amd/common/block/acpi/alib.c:

https://review.coreboot.org/c/coreboot/+/66994/comment/a79aa7d2_9610244e 
PS9, Line 43: acpigen_pop_len(); /* Method DDEF */
acpigen_write_method_end();

https://review.coreboot.org/c/coreboot/+/66994/comment/edb570b0_fe0e703a 
PS9, Line 45: acpigen_pop_len(); /* Scope _SB */
acpigen_write_scope_end();

Same for lines 72 and 74. They are self-explanatory - not needing a comment.