Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... PS4, Line 2964: * Writes 128 * 8 bytes in a loop
Replaced the comment with a description why it's done like that.
Ack
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... PS4, Line 2965: * Bank bits are located at bit 13:15 in physical memory map : * Rowbits start at bit 20 in physical memory map
Moved to CB:40946
Ack
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... PS4, Line 2974: (ctrl->tRCD << 16) |
This delay is applied after this subsequence is completed, but before the next one starts. […]
Ah, then I meant the line below ;)
https://review.coreboot.org/c/coreboot/+/40721/5/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/5/src/northbridge/intel/sandy... PS5, Line 2967: accieved achieved