[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48286/7/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/48286/7/src/soc/intel/common/block/... 
PS7, Line 416: edi
> I see you went back to using edi. […]

Yes Furquan. I was testing the change yesterday. I observed the system hang with original change. I was looking at the code again, while writing to 0x1891 MSR, we are utilizing the ecx in below command. So it no longer holds the number of ways. Can you and Tim please provide your thoughts?
movl	$IA32_CR_SF_QOS_MASK_1, %ecx