David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39628 )
Change subject: mb/ocp/tiogapass: Set BIOS_REGION_SIZE for FSP-T code caching
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39628/2/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/39628/2/src/mainboard/ocp/tiogapass...
PS2, Line 44: config BIOS_REGION_SIZE
If this is only used in one place and is constant, then a #define is preferable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6070974db1db54cb12109044a1f720ee7585a1f
Gerrit-Change-Number: 39628
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Mar 2020 17:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment