build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33488 )
Change subject: drivers/ipmi: Fix multiple issues ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/33488/1/src/drivers/ipmi/ipmi_kcs.c File src/drivers/ipmi/ipmi_kcs.c:
https://review.coreboot.org/#/c/33488/1/src/drivers/ipmi/ipmi_kcs.c@158 PS1, Line 158: if ((ret = ipmi_kcs_send_cmd_byte(port, IPMI_KCS_END_WRITE))) { do not use assignment in if condition
https://review.coreboot.org/#/c/33488/1/src/drivers/ipmi/ipmi_kcs.c@163 PS1, Line 163: if ((ret = ipmi_kcs_send_last_data_byte(port, cmd))) { do not use assignment in if condition
https://review.coreboot.org/#/c/33488/1/src/drivers/ipmi/ipmi_kcs.c@168 PS1, Line 168: if ((ret = ipmi_kcs_send_data_byte(port, cmd))) { do not use assignment in if condition
https://review.coreboot.org/#/c/33488/1/src/drivers/ipmi/ipmi_kcs.c@183 PS1, Line 183: if ((ret = ipmi_kcs_send_cmd_byte(port, IPMI_KCS_END_WRITE))) { do not use assignment in if condition
https://review.coreboot.org/#/c/33488/1/src/drivers/ipmi/ipmi_kcs.c@188 PS1, Line 188: if ((ret = ipmi_kcs_send_last_data_byte(port, *msg++))) { do not use assignment in if condition