Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Michael Niewöhner, Andrey Petrov.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62942 )
Change subject: drivers/intel/fsp2_0: Add provision to extract FSP Performance Data
......................................................................
Patch Set 7:
(1 comment)
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/62942/comment/ed5fb974_70b99f19
PS7, Line 248: if (CONFIG(DISPLAY_FSP_TIMESTAMPS))
: fsp_display_timestamp();
:
Ok, then let's keep it after whole silicon init. Is multi-phase init surely finished after do_silicon_init, or does it continue asynchronously?
yes, when you see "FspSiliconInitApi() - [Status: 0x00000000] - End" prints, both FSP_S and MultiPhaseSiInit are done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62942
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1b7f6b98bafeec0afe843f0f78c99c2f34f50b3
Gerrit-Change-Number: 62942
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Fri, 01 Apr 2022 10:46:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment