build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39658 ) Change subject: mb/asrock/q1900m: Add new mainboard ...................................................................... Patch Set 12: (2 comments) https://review.coreboot.org/c/coreboot/+/39658/12/src/mainboard/asrock/q1900... File src/mainboard/asrock/q1900m/irqroute.h: https://review.coreboot.org/c/coreboot/+/39658/12/src/mainboard/asrock/q1900... PS12, Line 7: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses https://review.coreboot.org/c/coreboot/+/39658/12/src/mainboard/asrock/q1900... PS12, Line 23: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/39658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id029074e4231db231a68bc92a4210dc052bba1c9 Gerrit-Change-Number: 39658 Gerrit-PatchSet: 12 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 30 Aug 2020 22:44:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment