build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33016 )
Change subject: src/driver/vpd: Update lib_vpd from upstream ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.h File src/drivers/vpd/lib_vpd.h:
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.h@96 PS3, Line 96: const uint32_t max_len, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.h@98 PS3, Line 98: uint32_t *length, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.h@99 PS3, Line 99: uint32_t *decoded_len); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.h@155 PS3, Line 155: const uint32_t max_len, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.h@157 PS3, Line 157: uint32_t *consumed, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.c File src/drivers/vpd/lib_vpd.c:
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.c@88 PS3, Line 88: if (VPD_OK != retval) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.c@104 PS3, Line 104: if (VPD_OK != retval) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/33016/3/src/drivers/vpd/lib_vpd.c@122 PS3, Line 122: break; break is not useful after a goto or return