Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31715 )
Change subject: src: Drop unused include <arch/acpi.h> ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/31715/2/src/mainboard/asus/kcma-d8/romstage.... File src/mainboard/asus/kcma-d8/romstage.c:
https://review.coreboot.org/#/c/31715/2/src/mainboard/asus/kcma-d8/romstage.... PS2, Line 23: #include <arch/acpi.h> Your commit message is about dropping and does not mention adding. Why do you need to add it anyway here? Because you dropped it in another file and it was included indirect? If this is the case, please make it clear it in the commit message.
https://review.coreboot.org/#/c/31715/2/src/mainboard/asus/kgpe-d16/romstage... File src/mainboard/asus/kgpe-d16/romstage.c:
https://review.coreboot.org/#/c/31715/2/src/mainboard/asus/kgpe-d16/romstage... PS2, Line 23: #include <arch/acpi.h> same
https://review.coreboot.org/#/c/31715/2/src/mainboard/getac/p470/mainboard.c File src/mainboard/getac/p470/mainboard.c:
https://review.coreboot.org/#/c/31715/2/src/mainboard/getac/p470/mainboard.c... PS2, Line 17: #include <arch/acpi.h> same