Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38826 )
Change subject: mb/google/hatch: Create nightfury variant ......................................................................
Patch Set 4:
(4 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38826/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38826/3//COMMIT_MSG@9 PS3, Line 9: Create new variant for nightfury
missing a period at the end.
Done
https://review.coreboot.org/c/coreboot/+/38826/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38826/3/src/mainboard/google/hatch/... PS3, Line 7: : [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
Shouldn't these be disabled?
I think it is another CML-based Samsung device, which is a better reference in this case.
https://review.coreboot.org/c/coreboot/+/38826/3/src/mainboard/google/hatch/... PS3, Line 11: [PchSerialIoIndexI2C5] = PchSerialIoPci,
And this one as well?
I think it is another CML-based Samsung device, which is a better reference in this case.
https://review.coreboot.org/c/coreboot/+/38826/3/src/mainboard/google/hatch/... PS3, Line 53: .i2c[3] = { : .speed = I2C_SPEED_FAST, : },
It's disabled in the devicetree
I think it is another CML-based Samsung device, which is a better reference in this case.