18 May
2017
18 May
'17
5:40 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19698 )
Change subject: detachables: Add invert parameter ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/#/c/19698/8/payloads/libpayload/drivers/video/gr... File payloads/libpayload/drivers/video/graphics.c:
PS8, Line 122: 00 Does the upper byte not matter?
PS8, Line 570: 0x000000ff PIVOT_MASK
https://review.coreboot.org/#/c/19698/8/payloads/libpayload/include/cbgfx.h File payloads/libpayload/include/cbgfx.h:
PS8, Line 161: 8 INVERT_SHIFT
PS8, Line 161: INVERT_COLORS Can we define the shift and mask in this file so that all the macros are together.
--
To view, visit https://review.coreboot.org/19698
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide6893a26f19eb2490377d4d53366ad145a9e6e3
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-HasComments: Yes