Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32701 )
Change subject: arch/cpu: Rename mp_get_apic_id() function ......................................................................
Patch Set 1:
(2 comments)
Before going deeper into this, what platforms (of interest) still don't use PARALLEL_MP? Would it be worth to port them forward instead?
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@200 PS1, Line 200: info->cpu = dev_find_path(NULL, DEVICE_PATH_CPU_CLUSTER); I fear, this sets the wrong device, so the APIC id (line 205) would not be updated correctly.
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@976 PS1, Line 976: MP_FR_BLOCK_APS(mp_initialize_cpu, mp_initialize_cpu), Order is critical here. For instance many CPUs do a second microcode load here that has to happen after SMM is set up.