Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38463 )
Change subject: mainboard/system76: Add System76 Lemur Pro (lemp9) ......................................................................
Patch Set 12: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38463/12/Documentation/mainboard/sy... File Documentation/mainboard/system76/lemp9.md:
https://review.coreboot.org/c/coreboot/+/38463/12/Documentation/mainboard/sy... PS12, Line 21: - Memory I guess channel 0 is memory-down (on-board RAM)? It would be good to state that. I would also put the "Channel x" part at the beginning:
- Channel 0: 8 GB on-board DDR4 Samsung K4AAG165WA-BCTD - Channel 1: 8 GB/16 GB/32 GB DDR4 SO-DIMM
https://review.coreboot.org/c/coreboot/+/38463/12/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/acpi/s76.asl:
https://review.coreboot.org/c/coreboot/+/38463/12/src/mainboard/system76/lem... PS12, Line 107: Method (GKBL, 0, Serialized) { Does the color keyboard need this GKBL method?