Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email )
Change subject: mb/google/rauru: Add edp driver in mainboard
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/rauru/panel_navi.c:
PS2:
Done
Here is different, where the Navi function is called when FW config is oled. The function name should match the caller condition. For example, if there is a future 8196 device that also uses oled, the we don't want to duplicate that file.
https://review.coreboot.org/c/coreboot/+/85951/comment/7fee0b86_a6c5ceba?usp... :
PS2, Line 15: struct panel_description *get_navi_description(void);
Done
Yes, create a new header.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85951?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea610c97351beb94a49cc1044701a523b7c85a6e
Gerrit-Change-Number: 85951
Gerrit-PatchSet: 6
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bincai Liu
bincai.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Sat, 18 Jan 2025 04:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bincai Liu
bincai.liu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com