21 Dec
2020
21 Dec
'20
9:54 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )
Change subject: mb/pcengines/apu2: Switch to proper GPIO API ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42521/13/src/mainboard/pcengines/ap... File src/mainboard/pcengines/apu2/gpio_ftns.c:
https://review.coreboot.org/c/coreboot/+/42521/13/src/mainboard/pcengines/ap... PS13, Line 14: GPIO_49 did you verify that this is the correct gpio number? haven't looked in the datasheet, but from the datasheets of picasso, renoir and cezanne i expected this to be gpio 64 and the next one gpio 65
--
To view, visit https://review.coreboot.org/c/coreboot/+/42521
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I348ba43a76287be5b24012ae3dfc28ed783da9c7
Gerrit-Change-Number: 42521
Gerrit-PatchSet: 13
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Dec 2020 20:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment