build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38986 )
Change subject: WIP: IIO work ......................................................................
Patch Set 1:
(15 comments)
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c File src/cpu/intel/xeonsp/iio.c:
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 24: for (int s=0; s < hob->PlatformData.numofIIO; ++s) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 25: for (int x=0; x < MAX_IIO_STACK; ++x) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 27: if (ri->BusBase < ri->BusLimit) // TODO: do we have situation with only bux 0 and one stack? line over 96 characters
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 40: for (int s=0; s < hob->PlatformData.numofIIO; ++s) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 41: for (int x=0; x < MAX_IIO_STACK; ++x) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 43: if (ri->BusBase < ri->BusLimit) // TODO: do we have situation with only bux 0 and one stack? line over 96 characters
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 58: for (int s=0; s < stack_info.no_of_stacks; ++s) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 59: printk(BIOS_DEBUG, "Attaching stack 0x%x to device %s\n", stack_info.sres[s].BusBase, dev_path(dev)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 60: if (stack_info.sres[s].BusBase == 0) /* only non zero bus no. needs to be enumerated */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 65: die("attach_iio_stacks(): out of memory.\n"); Prefer using '"%s...", __func__' to using 'attach_iio_stacks', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 80: printk(BIOS_WARNING, "IIO Stack device %s not visible\n", dev_path(&dummy)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/iio.c@... PS1, Line 85: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/includ... File src/cpu/intel/xeonsp/include/soc/fsp_hobs.h:
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/includ... PS1, Line 21: 0xa1, 0x96, 0xf3, 0x7f, 0x7d, 0xee, 0x1e, 0x43, \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/includ... PS1, Line 22: 0xba, 0x53, 0x8f, 0xCa, 0x12, 0x7c, 0x44, 0xc0 \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/includ... File src/cpu/intel/xeonsp/include/soc/iio.h:
https://review.coreboot.org/c/coreboot/+/38986/1/src/cpu/intel/xeonsp/includ... PS1, Line 14: #endif adding a line without newline at end of file